Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Console Monaco migration] Resize the editor on window resize #184352

Closed
yuliacech opened this issue May 28, 2024 · 3 comments
Closed

[Console Monaco migration] Resize the editor on window resize #184352

yuliacech opened this issue May 28, 2024 · 3 comments
Labels
Feature:Console Dev Tools Console Feature Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@yuliacech
Copy link
Contributor

The Ace editor keeps the split between editor and output panel in relation to each other when the window is resized. The Monaco editor doesn't react to the window resize in the same manner. See screen recording below

Ace

Screen.Recording.2024-05-28.at.14.42.08.mov

Monaco

Screen.Recording.2024-05-28.at.14.44.17.mov
@yuliacech yuliacech added Feature:Console Dev Tools Console Feature Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more labels May 28, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-management (Team:Kibana Management)

@sabarasaba
Copy link
Member

I just gave it a go locally, and seems the aspect ratio is maintained although it has a small animation as the text wrapping is happening:

Screen.Recording.2024-07-30.at.13.11.24.mov

@yuliacech
Copy link
Contributor Author

Thanks a lot for checking, @sabarasaba!
This issue is not reproducible anymore, closing

@yuliacech yuliacech closed this as not planned Won't fix, can't repro, duplicate, stale Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Console Dev Tools Console Feature Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Development

No branches or pull requests

3 participants