-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for a global SCSS file #20859
Comments
Just some fair warning, we're working through the plugins at the moment so we're still good without this, but I'm guessing in about 2 weeks we'll be blocked by it. Still think a hardcoded reference in your build scripts is likely (src/ui/index.scss or similar) would be ok. We will only need one file built for this part. It's mostly the load order in the document that matters to us. |
Gonna need this one fairly soon. Would still like to get all of the less converted by 6.5 and this will be a blocker. |
Thanks for the heads up @snide. Will try to get this in soon. |
I think we're at a point where this might block us from getting all of the sass work done in 6.5. We have planned:
All the other styling (which is the majority of styles) live either as a global (src/ui) or have mixed usage between xpack and core (management...etc). We're gonna try and take on some of the files we know don't change often (like Watcher) in anticipation of the build solution dropping, but because of the amount of code changing (as well as file moves), they make rebases very difficult so can't sit around too long. |
#19643 (comment) added the ability for plugins to generate css files from sass included in plugins.
What we'll also need need is a way to generate a core (across every kibana page) css file (from a scss file) that is included on every Kibana page.
As an example... here is what the load order of css on a random app within kibana should look like:
Right now the equivalent of kibana.css lives in
src/ui/public/styles
Less files and is generated instyles.js
I don't think this would ever require something complicated, so it could be a hardcoded
src/public/index.scss
file if we wanted. The sass watcher would just need to generate a css file from that location and then reference itself in Kibana's chrome.The text was updated successfully, but these errors were encountered: