Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uiSettings should emit default when userValue is cleared #22668

Closed
spalger opened this issue Sep 4, 2018 · 0 comments
Closed

uiSettings should emit default when userValue is cleared #22668

spalger opened this issue Sep 4, 2018 · 0 comments
Labels
chore stale Used to mark issues that were closed for being stale Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@spalger
Copy link
Contributor

spalger commented Sep 4, 2018

As @azasypkin pointed out in #22623 (review), uiSettings.subscribe() emits null when the userValue is cleared, it should probably emit the actual value though. This isn't current causing any known bugs, but representing defaults as null is an internal detail of the uiSettings that really shouldn't be exposed like this.
@spalger spalger added chore Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc labels Sep 4, 2018
@joshdover joshdover added the stale Used to mark issues that were closed for being stale label Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore stale Used to mark issues that were closed for being stale Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@spalger @joshdover