Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix i18n engine initialization order #23903

Closed
maryia-lapata opened this issue Oct 8, 2018 · 0 comments · Fixed by #23902
Closed

Fix i18n engine initialization order #23903

maryia-lapata opened this issue Oct 8, 2018 · 0 comments · Fixed by #23902
Assignees
@maryia-lapata
Labels
Project:i18n Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@maryia-lapata
Copy link
Contributor

Issue: Since Notifications are rendered before i18n engine initializing with specified locale, labels in Notifications are not localized with the specified locale, they are displayed in default locale.

Solution: initialize i18n engine before Notifications are rendered.
@maryia-lapata maryia-lapata self-assigned this Oct 8, 2018
@maryia-lapata maryia-lapata mentioned this issue Oct 8, 2018
Merged
@bhavyarm bhavyarm added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maryia-lapata maryia-lapata

Labels
Project:i18n Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Init I18n before Notifications start maryia-lapata/kibana
2 participants
@bhavyarm @maryia-lapata