Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Waterfall request breaks on a v1 transaction #24618

Closed
jasonrhodes opened this issue Oct 26, 2018 · 1 comment
Closed

[APM] Waterfall request breaks on a v1 transaction #24618

jasonrhodes opened this issue Oct 26, 2018 · 1 comment
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Team:APM All issues that need APM UI Team support v6.5.0

Comments

@jasonrhodes
Copy link
Member

jasonrhodes commented Oct 26, 2018

When visiting a v1 transaction page, the page blows up with:

Uncaught TypeError: Cannot read property 'find' of undefined

This was originally caught by @formgeist and mentioned in #24556 - #24556 (comment)

Short-term, the fix is to short-circuit the waterfall selector entirely if it doesn't have the right data structure, but long term we should transfer the conversion we are doing in RRR's render function into a dispatched action so the data is stored the same way in v1 and v2 waterfalls.

@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui

@jasonrhodes jasonrhodes self-assigned this Oct 26, 2018
@jasonrhodes jasonrhodes added Team:APM All issues that need APM UI Team support [zube]: Inbox bug Fixes for quality problems that affect the customer experience and removed [zube]: Inbox labels Oct 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Team:APM All issues that need APM UI Team support v6.5.0
Projects
None yet
Development

No branches or pull requests

3 participants