Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Visual regression in timeline #24817

Closed
sorenlouv opened this issue Oct 30, 2018 · 4 comments
Closed

[APM] Visual regression in timeline #24817

sorenlouv opened this issue Oct 30, 2018 · 4 comments
Assignees
@jasonrhodes
Labels
Team:APM All issues that need APM UI Team support

Comments

@sorenlouv
Copy link
Member

sorenlouv commented Oct 30, 2018 •
edited
Loading

There used to be a minimum width for transactions/spans, so they were visible. Also, the text would flow left when there was no more space on the right:

Before:
screen shot 2018-10-30 at 09 44 51

After:
screen shot 2018-10-30 at 09 45 04
@sorenlouv sorenlouv added Team:APM All issues that need APM UI Team support [zube]: Impl Ready labels Oct 30, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui

@alvarolobato
Copy link

This should also close #18680

@sorenlouv
Copy link
Member Author

This is how it was previously accomplished:
https://github.com/sqren/kibana/blob/a353979ebbca723bde1f07e0bfe2acf9241ad3e0/x-pack/plugins/apm/public/components/app/TransactionDetails/Transaction/Spans/Span.js#L30-L45

A simplified codepen that demonstrates the approach:
https://codepen.io/sqren/pen/JrXNjY

@jasonrhodes jasonrhodes self-assigned this Oct 30, 2018
@jasonrhodes jasonrhodes mentioned this issue Oct 30, 2018
Closed
7 tasks
@jasonrhodes
Copy link
Member

This ticket is now included in #24578

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jasonrhodes jasonrhodes

Labels
Team:APM All issues that need APM UI Team support
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jasonrhodes @sorenlouv @elasticmachine @alvarolobato