Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsx-a11y errors in automcomplete.js, invalid_element_type.js and invalid_expression.js #24905

Closed
3 tasks
bhavyarm opened this issue Oct 31, 2018 · 0 comments
Closed
3 tasks
Labels
bug Fixes for quality problems that affect the customer experience Feature:Canvas impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. loe:medium Medium Level of Effort Project:Accessibility Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas WCAG A

Comments

@bhavyarm
Copy link
Contributor

bhavyarm commented Oct 31, 2018

Kibana version: master canvas

Error https://www.npmjs.com/package/eslint-plugin-jsx-a11y :

  • Autocomplete.js:
/Users//Desktop/jsx-kibana/kibana/x-pack/plugins/canvas/public/components/autocomplete/autocomplete.js
  181:7   error  Elements with the 'combobox' interactive role must be focusable                                                 jsx-a11y/interactive-supports-focus
  187:9   error  Elements with the ARIA role "combobox" must have the following attributes defined: aria-controls,aria-expanded  jsx-a11y/role-has-required-aria-props
  209:23  error  Elements with the 'option' interactive role must be focusable                                                   jsx-a11y/interactive-supports-focus
  218:25  error  Elements with the ARIA role "option" must have the following attributes defined: aria-selected                  jsx-a11y/role-has-required-aria-props

  • invalid__element_type.js:
/Users/bhavyarajumandya/Desktop/jsx-kibana/kibana/x-pack/plugins/canvas/public/components/element_content/invalid_element_type.js
  11:3  error  Non-interactive elements should not be assigned mouse or keyboard event listeners  jsx-a11y/no-noninteractive-element-interactions
  • invalid_expression.js:
/Users/bhavyarajumandya/Desktop/jsx-kibana/kibana/x-pack/plugins/canvas/public/components/element_content/invalid_expression.js
  11:3  error  Non-interactive elements should not be assigned mouse or keyboard event listeners  jsx-a11y/no-noninteractive-element-interactions
@bhavyarm bhavyarm added Project:Accessibility bug Fixes for quality problems that affect the customer experience Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Oct 31, 2018
@bhavyarm bhavyarm changed the title jsx-a11y errors in automcomplete.js jsx-a11y errors in automcomplete.js, invalid_element_type.js and invalid_expression.js Oct 31, 2018
@bhavyarm bhavyarm added the WCAG A label Nov 6, 2018
@cqliu1 cqliu1 added Feature:Add Data Add Data and sample data feature on Home loe:medium Medium Level of Effort and removed Feature:Add Data Add Data and sample data feature on Home labels Mar 19, 2019
@clintandrewhall clintandrewhall added the impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. label Mar 1, 2021
@crob611 crob611 self-assigned this Apr 26, 2021
@nickpeihl nickpeihl added the impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. label Jan 26, 2023
@ThomThomson ThomThomson closed this as not planned Won't fix, can't repro, duplicate, stale Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Canvas impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. loe:medium Medium Level of Effort Project:Accessibility Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas WCAG A
Projects
None yet
Development

No branches or pull requests

7 participants