Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entering text in the Advanced Settings search bar that isn't valid AST causes page to crash #25143

Closed
peteharverson opened this issue Nov 5, 2018 · 4 comments
Assignees
Labels
bug Fixes for quality problems that affect the customer experience

Comments

@peteharverson
Copy link
Contributor

Kibana version: 6.5.0

If text is entered into the search bar in the Advanced Settings page under the Management tab that isn't valid AST, the page crashes.

For example type in ? into the search bar on the page:

image

causes:

image

@peteharverson peteharverson added bug Fixes for quality problems that affect the customer experience :Management labels Nov 5, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-management

@cjcenizal
Copy link
Contributor

cjcenizal commented Nov 5, 2018

On the EuiSearchBar example the error is handled like this:

  onChange = ({ query, error }) => {
    if (error) {
      this.setState({ error });
    } else {
      this.setState({
        error: null,
        result: EuiSearchBar.Query.execute(query, items, { defaultFields: ['owner', 'tag', 'type'] }),
        query
      });
    }
  };

image

@nreese
Copy link
Contributor

nreese commented Nov 5, 2018

@cjcenizal Same thing happens on the saved object management page if you enter ? in the search box

@cjcenizal
Copy link
Contributor

For further context, the original bug reported was introduced in 6.4 (#17465) and the saved objects bug was also introduced in 6.4 (#17426)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience
Projects
None yet
Development

No branches or pull requests

4 participants