Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for RareTerms aggregation #26340

Closed
alexfrancoeur opened this issue Nov 28, 2018 · 5 comments
Closed

Add support for RareTerms aggregation #26340

alexfrancoeur opened this issue Nov 28, 2018 · 5 comments
Labels
Feature:Aggregations Aggregation infrastructure (AggConfig, esaggs, ...) good first issue low hanging fruit Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@alexfrancoeur
Copy link

The Elasticsearch team is currently working on a new aggregation called the RareTerms aggregation (elastic/elasticsearch#35718, elastic/elasticsearch#20586). This will eventually deprecate / remove the ability to sort a terms aggregation by ascending count (elastic/elasticsearch#17614). Ordering this way has unbounded error and the results may not be accurate given the way a terms aggregation and shards work. The new RareTerms agg has a different algorithm that allows it to track the longtail or "rare" terms in a memory efficient manner without having to maintain a complete ordering of all terms.

If the plan is to deprecate the ability to sort a terms agg by ascending count in 7.0 and completely remove in 8.0, Kibana will need to add support for the RareTerms agg in 7.x so our users can migrate over to the more accurate algorithm.

@alexfrancoeur alexfrancoeur added Feature:Aggregations Aggregation infrastructure (AggConfig, esaggs, ...) Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Nov 28, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@timroes timroes added the good first issue low hanging fruit label Jan 23, 2019
@rrtheonlyone
Copy link

@alexfrancoeur I would like to help out with this issue. Any guidance on where I should start looking?

@polyfractal
Copy link
Contributor

@rrtheonlyone The RareTerms agg hasn't merged into ES yet, although I'm hopeful it will be very soon. So work in Kibana will probably have to wait until the agg finalizes and gets merged :)

@timroes timroes added the blocked label Mar 1, 2019
@polyfractal
Copy link
Contributor

Just FYI, elastic/elasticsearch#35718 has merged. We still don't know when or if we are going to deprecate sorting count ascending on terms agg, so no rush to replace it.

RareTerms has it's own limitations and semantics so we may never be able to deprecate count ascending, despite the unbounded error aspect :( We'll see.

@Dosant
Copy link
Contributor

Dosant commented Jan 31, 2022

Implemented in AggConfigs and Lens in #121500

@Dosant Dosant closed this as completed Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Aggregations Aggregation infrastructure (AggConfig, esaggs, ...) good first issue low hanging fruit Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

6 participants