Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http interception responseError missing request #42307

Closed
kobelb opened this issue Jul 30, 2019 · 2 comments · Fixed by #42755
Closed

http interception responseError missing request #42307

kobelb opened this issue Jul 30, 2019 · 2 comments · Fixed by #42755
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@kobelb
Copy link
Contributor

kobelb commented Jul 30, 2019

According to the HttpResponseError types the responseError interceptor should have access to the request. However, responseError only gets the request when one of the response handlers are hit, because this then hits

current = (await interceptor.response(httpResponse, controller)) || httpResponse;

This line

let current: HttpResponse;
somehow makes TypeScript not pick up on this, I assume because anything can be undefined? If we change this line to let current: HttpResponse | undefined; then we start getting type errors.

@kobelb kobelb added bug Fixes for quality problems that affect the customer experience Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc labels Jul 30, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform

@kobelb
Copy link
Contributor Author

kobelb commented Aug 5, 2019

/cc @eliperelman I saw that you self-assigned #42311, will you be fixing this issue as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
3 participants