Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate ui/doc_title to New Platform #46077

Closed
joshdover opened this issue Sep 18, 2019 · 2 comments · Fixed by #48121
Closed

Migrate ui/doc_title to New Platform #46077

joshdover opened this issue Sep 18, 2019 · 2 comments · Fixed by #48121
Assignees
@pgayvallet
Labels
Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@joshdover
Copy link
Contributor

We need to migrate the ui/doc_title package to the New Platform. This module allows plugins to update the document title.

It seems to me this would make sense to live inside the ChromeService because it represents the user's current location similar to breadcrumbs. In fact, depending on how this is used, maybe we should derive the document title from the breadcrumbs rather than having every plugin integrate with this explicitly.
@joshdover joshdover added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:New Platform labels Sep 18, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform

@joshdover joshdover mentioned this issue Sep 24, 2019
Closed
@joshdover
Copy link
Contributor Author

Do the simplest thing now, make fancy later.

@kertal kertal mentioned this issue Oct 3, 2019
Closed
46 tasks
@pgayvallet pgayvallet self-assigned this Oct 14, 2019
@pgayvallet pgayvallet mentioned this issue Oct 14, 2019
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pgayvallet pgayvallet

Labels
Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrate ui/doc_title to New platform pgayvallet/kibana
3 participants
@pgayvallet @joshdover @elasticmachine