Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase maxPayloadBytes on Saved Object API for Canvas Workpads #46819

Closed
timductive opened this issue Sep 27, 2019 · 7 comments
Closed

Increase maxPayloadBytes on Saved Object API for Canvas Workpads #46819

timductive opened this issue Sep 27, 2019 · 7 comments
Labels
discuss Feature:Canvas Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@timductive
Copy link
Member

timductive commented Sep 27, 2019

Describe the feature:
Currently the default limit for the Saved Object API is 10MB, many Canvas workpads exceed this limit and can't be uploaded via the Saved Object API. Canvas has an internal API that overrides the limit to 25MB, ideally we could use the Saved Object API both internally and externally and users could override this limit.

@timductive timductive added discuss Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Team:AppArch labels Sep 27, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-canvas

@timductive
Copy link
Member Author

related to #43678

@lukeelmers lukeelmers added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc and removed Team:AppArch labels Dec 10, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

@pgayvallet
Copy link
Contributor

pgayvallet commented Dec 11, 2019

Once #50321 lands, we could increase the maxBytes option of saved object routes, either with a static value or an actual config property.

  • Is there any reason not to do so?
  • What actual value make sense?
  • Which SO routes should actually impacted?

CC @rudolf @joshdover

EDIT: once #50321 lands, server.maxPayloadBytes should actually be applied by default to SO routes. The question of increasing it by default still remains.

@mshustov
Copy link
Contributor

mshustov commented Dec 12, 2019

We use the same Hapi instance for both the New & Legacy platforms. It means that default value server.maxPayloadBytes: 1Mb is used for all routes.
SO routes are declared in the Legacy platform. We can adjust payload value on a route base already now
https://github.com/elastic/kibana/blob/master/src/legacy/server/http/integration_tests/max_payload_size.test.js#L32

Or you are talking about maxImportPayloadBytes ? Which is used for /api/saved_objects/_import and /api/saved_objects/_resolve_import_errors with default 10Mb
https://github.com/elastic/kibana/blob/master/src/legacy/server/config/schema.js#L253

@ThomThomson
Copy link
Contributor

Closing this for the moment as not planned. We can re-open again if it becomes a priority to increase this limit

@ThomThomson ThomThomson closed this as not planned Won't fix, can't repro, duplicate, stale Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Feature:Canvas Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

No branches or pull requests

7 participants