Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] De-angularize & EUI-ficate sidebar field filter form #47357

Closed
kertal opened this issue Oct 4, 2019 · 2 comments
Closed

[Discover] De-angularize & EUI-ficate sidebar field filter form #47357

kertal opened this issue Oct 4, 2019 · 2 comments
Assignees
@majagrubic
Labels
chore Feature:Discover Discover Application Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@kertal
Copy link
Member

kertal commented Oct 4, 2019 •
edited
Loading

Here's the part of the sidebar that's still angular, and needs to be migrated to the EUI world.
image

Here's the Angular template that contains the current form:

https://github.com/elastic/kibana/blob/master/src/legacy/core_plugins/kibana/public/discover/components/field_chooser/field_chooser.html#L17
@mistic mistic added chore Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Oct 8, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@kertal kertal added the Feature:Discover Discover Application label Oct 8, 2019
@kertal kertal mentioned this issue Oct 11, 2019
Merged
6 tasks
@kertal kertal changed the title [Discover] De-angularize & EUI-ficate sidebar field filter [Discover] De-angularize & EUI-ficate sidebar field filter form Oct 14, 2019
@majagrubic majagrubic mentioned this issue Oct 16, 2019
Merged
7 tasks
@kertal
Copy link
Member Author

kertal commented Nov 14, 2019

Done is done!

@kertal kertal closed this as completed Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@majagrubic majagrubic

Labels
chore Feature:Discover Discover Application Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kertal @majagrubic @mistic @elasticmachine