Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] (Accessibility) Multiple Accessibility Best Practice Issues on Machine Learning Overview Page - MAIN Landmark #51076

Closed
barlowm opened this issue Nov 19, 2019 · 3 comments

Comments

@barlowm
Copy link
Collaborator

barlowm commented Nov 19, 2019

Multiple Best Practice issues on Machine Learning Overview Page
These are not explicitly WCAG 2.1 violations but they do violate WAI-ARIA best practices and should be addressed.

<main class="application tab-overview" >
    ... Additional Code ...
    <main class="euiPageBody">
        ... Additional Code ...
    </main>
    ... Additional Code ...
</main>

Kibana Version:
7.5.0 BC2

OS:
Windows

Browser:
Chrome

Screen reader: [if relevant]
N/A

Relevant WCAG Criteria: WCAG Quick Reference

Relevant ARIA spec: WAI-ARIA Authoring Practices 1.1
WAI-ARIA Landmark Regions

@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@barlowm barlowm changed the title [ML] (Accessibility) Multiple Accessibility Best Practice Issues on Overview Page [ML] (Accessibility) Multiple Accessibility Best Practice Issues on Machine Learning Overview Page Nov 19, 2019
@barlowm
Copy link
Collaborator Author

barlowm commented Dec 4, 2019

The same issue also exists on the following pages within Machine Learning (and probably many more but it is not an issue on ALL pages:

"Anomaly Detection / Settings",
settings

"Anomaly Detection / Job Management / Create Job",
Select "kibana_sample_data_flights"
Select "Single metric" wizard
Step4

"Data Frame Analytics"
analytics

"Data Visualizer"
visualizer

@barlowm barlowm changed the title [ML] (Accessibility) Multiple Accessibility Best Practice Issues on Machine Learning Overview Page [ML] (Accessibility) Multiple Accessibility Best Practice Issues on Machine Learning Overview Page - MAIN Landmark Dec 6, 2019
@peteharverson peteharverson self-assigned this Jan 17, 2020
@peteharverson
Copy link
Contributor

peteharverson commented Jan 17, 2020

This has been fixed in 7.6.0 by the replacement of Angular routing in #51842, so that the pages now only contain one <main> landmark. The top-level application class level element is now rendered in a <div> rather than a <main>.

7.5.0:
image

7.6.0:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants