Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snapshot Retention Policy allows selection for negative number of snapshots #51134

Closed
cuff-links opened this issue Nov 19, 2019 · 5 comments
Closed
Labels
bug Fixes for quality problems that affect the customer experience Feature:Snapshot and Restore Elasticsearch snapshots and repositories UI good first issue low hanging fruit Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@cuff-links
Copy link
Contributor

Environment:
Elasticsearch: 7.5.0 BC 5
Kibana 7.5.0 BC 5
Browser: All

Steps to reproduce:
1.) Start or edit a snapshot policy
2.) On step 3 (snapshot retention), select negative numbers for any of the fields.
3.) Click Next
Expected Result:
The client side validation validates that the number of days and the number of snapshots cannot be configured to a negative number.

Actual Result:
Values are accepted and you move to the next page where the erroneous values are displayed. Still no validation. Doesn't get validated until you hit save and ES validates on the server.

@cuff-links cuff-links added bug Fixes for quality problems that affect the customer experience Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.5.0 labels Nov 19, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@cuff-links
Copy link
Contributor Author

Screen Shot 2019-11-19 at 6 50 31 PM

Screen Shot 2019-11-19 at 6 49 25 PM

@cuff-links
Copy link
Contributor Author

/cc @alisonelizabeth

@cuff-links cuff-links removed the v7.5.0 label Nov 20, 2019
@cuff-links cuff-links changed the title Snapshot Retention Policy allows selection for negative number os snapshots Snapshot Retention Policy allows selection for negative number of snapshots Nov 20, 2019
@alisonelizabeth alisonelizabeth added Feature:Snapshot and Restore Elasticsearch snapshots and repositories UI good first issue low hanging fruit labels Nov 20, 2019
@ffknob
Copy link
Contributor

ffknob commented Nov 21, 2019

Here is my attempt on this: #51295

I just set the EuiFieldNumber prop min to 0 so the user cannot use the arrow controls to get to a negative number, but I also had to prevent entering manually the - symbol.

@alisonelizabeth
Copy link
Contributor

Fixed via #51295. Thanks @ffknob!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Snapshot and Restore Elasticsearch snapshots and repositories UI good first issue low hanging fruit Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Development

No branches or pull requests

4 participants