Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] (Accessibility) Machine Learning - Anomaly Detection / Create Job - Landmark Accessibility Best Practice Issue #52377

Closed
barlowm opened this issue Dec 6, 2019 · 2 comments

Comments

@barlowm
Copy link
Collaborator

barlowm commented Dec 6, 2019

Not explicitly WCAG 2.1 violations but they do violate WAI-ARIA best practices and should be addressed.

CreateJob

Steps to reproduce

  • From the Machine Leaning/Anomaly Detection/Job Management page, click the "Create new job" button.
  • On the "Select index pattern or saved search" page click the "[eCommerce] Orders" item
  • On the "Create a job from the saved search [eCommerce] Orders" page select the "Kibana sample data eCommerce" item
  • Use deque axe to reveal the issue, or view source and search for the "main" tag
<main class="application tab-overview" >
    ... Additional Code ...
    <main class="euiPageBody">
        ... Additional Code ...
    </main>
    ... Additional Code ...
</main>

Kibana Version:
7.5.0

OS:
Windows

Browser:
Chrome

Screen reader: [if relevant]
N/A

Relevant WCAG Criteria: WCAG Quick Reference

Relevant ARIA spec: WAI-ARIA Authoring Practices 1.1
WAI-ARIA Landmark Regions

@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@peteharverson peteharverson added the Feature:Anomaly Detection ML anomaly detection label Dec 6, 2019
@peteharverson
Copy link
Contributor

This has been fixed in 7.6.0 by the replacement of Angular routing in #51842, so that the pages now only contain one

landmark. The top-level application class level element is now rendered in a <div> rather than a <main>.

7.5.0:
image

7.6.0:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants