Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Transaction page throws unhandled exception if transactions doesn't have http.request #52648

Closed
hmdhk opened this issue Dec 10, 2019 · 2 comments · Fixed by #53760
Closed
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Team:APM All issues that need APM UI Team support

Comments

@hmdhk
Copy link
Contributor

hmdhk commented Dec 10, 2019

Kibana version: 8.0.0 snapshot

Elasticsearch version: 8.0.0 snapshot

Describe the bug:
The APM UI can't show transactions that have transaction.http but not transaction.http.request. More specifically this part of code fails and the APM UI structure disappears.

The reason that these transactions can be reported is because of the transaction.context.response proposal which introduces using transaction.context.response for RUM specific metrics.

Steps to reproduce:
0. Build a Chrome extension that injects the RUM agent into a website ;)

  1. Go to wikipedia.org to capture a RUM transaction
  2. Go to the transaction page

Expected behavior:
Show the transaction.

Errors in browser console (if relevant):

TypeError: Cannot read property 'method' of undefined
    at getTransactionResultSummaryItem (apm.bundle.js:3)
    at TransactionSummary (apm.bundle.js:3)
    at hg (vendors.bundle.dll.js:218)
    at Tg (vendors.bundle.dll.js:218)
    at bi (vendors.bundle.dll.js:218)
    at ci (vendors.bundle.dll.js:218)
    at Di (vendors.bundle.dll.js:218)
    at Yh (vendors.bundle.dll.js:218)
    at Xh (vendors.bundle.dll.js:218)
    at qf (vendors.bundle.dll.js:218)
@hmdhk hmdhk added bug Fixes for quality problems that affect the customer experience Team:APM All issues that need APM UI Team support labels Dec 10, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@sorenlouv
Copy link
Member

sorenlouv commented Dec 10, 2019

Sounds like http.request should be optional then:

export interface Http {
request: { method: string; [key: string]: unknown };
response?: { status_code: number; [key: string]: unknown };
version?: string;
}

@jahtalab Is this the case for http.request on both errors and transactions?

@sorenlouv sorenlouv changed the title [APM] Transaction page stops working for transactions with no http.request [APM] Transaction page throws unhandled exception if transactions doesn't have http.request Dec 11, 2019
@cauemarcondes cauemarcondes self-assigned this Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Team:APM All issues that need APM UI Team support
Projects
None yet
5 participants