Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Telemetry] Remove from and to timestamps from usage stats APIs #57782

Closed
Bamieh opened this issue Feb 17, 2020 · 4 comments · Fixed by #81579
Closed

[Telemetry] Remove from and to timestamps from usage stats APIs #57782

Bamieh opened this issue Feb 17, 2020 · 4 comments · Fixed by #81579
Assignees
Labels
Feature:Telemetry Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@Bamieh
Copy link
Member

Bamieh commented Feb 17, 2020

We depend on the API request to fetch the from and to date parameters for fetching usage data with monitoring.

We can remove this from the API and instead only send timestamp. The api can decide the from/to interval internally.

At the moment we have some cases where we override the 20 minutes interval sent from the browser.

CC @afharo

@elasticmachine
Copy link
Contributor

Pinging @elastic/pulse (Team:Pulse)

@afharo
Copy link
Member

afharo commented Mar 3, 2020

I think it makes perfect sense!
But it may require some additional changes (apart from providing timestamp instead of from and to) in the way the usageCollection manager calls the fetchers?
With the current telemetry, we only return snapshots, so I guess it will be fine for the usageCollector to define the query time range based on that unique timestamp.

But as we are approaching the Pulse logic, and more granular time-based data is supposed to come in, we may need to keep in mind an additional lastSuccessfulReport so we don't report the same data twice? It certainly is not related to this issue (or is it?) but just an open thought here.

@Bamieh
Copy link
Member Author

Bamieh commented Mar 4, 2020

@afharo i dont believe we should be relying on the user's timestamp at all. for the aggregate data (currnet telemetry) we can just send the latest snapshot regardless or user time. for event based documents (pulse documents) we can send documents based on the last reported timestamp or something. The team should discuss this further before writing an implementation.

@Bamieh Bamieh self-assigned this Oct 25, 2020
@lukeelmers lukeelmers added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Oct 1, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Telemetry Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants