Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate functional test for shared links #5917

Open
8 tasks
LeeDr opened this issue Jan 15, 2016 · 2 comments
Open
8 tasks

Automate functional test for shared links #5917

LeeDr opened this issue Jan 15, 2016 · 2 comments
Labels

Comments

@LeeDr
Copy link
Contributor

LeeDr commented Jan 15, 2016

We need automated tests for;

  • the regular iframe code fragments on visualizations
  • the shortened iframe code fragments on visualizations
  • the regular iframe code fragments on dashboard
  • the shortened iframe code fragments on dashboard
  • the regular share link on visualizations
  • the shortened share link on visualizations
  • the regular share link on dashboard
  • the shortened share link on dashboard

For the iframe code, we could just check that we got the exact right string, or (more complicated) we could build an html file, open it, and check for content.

@epixa
Copy link
Contributor

epixa commented Feb 29, 2016

@LeeDr Is there any chance of this getting in for 4.5 or should we remove that label?

@LeeDr LeeDr added v5.0.0 and removed v4.5.0 labels Feb 29, 2016
@LeeDr
Copy link
Contributor Author

LeeDr commented Feb 29, 2016

There are tests for Shared Links in the Discover tab in master and 4.x (4.5). Moving the rest of this to master (5.0).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants