Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circular dependencies in core #59460

Closed
rylnd opened this issue Mar 5, 2020 · 3 comments
Closed

Circular dependencies in core #59460

rylnd opened this issue Mar 5, 2020 · 3 comments
Labels
Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@rylnd
Copy link
Contributor

rylnd commented Mar 5, 2020

SIEM uses madge to check for circular dependencies in our client app. Attempting to use core mocks in tests broke our build, as it caused that check to fail.

We bypassed the issue for now (by not using those mocks), so this is mostly an FYI.

Related: #35303.

@rylnd rylnd added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Mar 5, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

@joshdover
Copy link
Contributor

Is this an actual issue? AFAIK, TypeScript support circular imports for types and I don't necessarily see how this causes any problems.

@rylnd
Copy link
Contributor Author

rylnd commented Mar 5, 2020

@joshdover right, this seems to all work out at runtime, I just wanted to bring it to the team's attention. I'll close it for now and reevaluate whether that script is providing any value 👍 .

@rylnd rylnd closed this as completed Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

No branches or pull requests

3 participants