Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move towards a modal confirmation/alert dialog rather than native alerts/confirmations #6003

Closed
jdavisclark opened this issue Jan 25, 2016 · 5 comments
Assignees
Labels
enhancement New value added to drive a business result Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins.

Comments

@jdavisclark
Copy link

this is mainly for discussion, but I would like to see Kibana move towards a more integrated alert/confirmation UI rather than depending on the native alert/confirm elements.

Native browser confirmations/alerts are almost becoming an anti-pattern; evidenced by the fact that lots of browsers start adding the "do you want to prevent more popups" option after one of two times.

@jdavisclark
Copy link
Author

this was brought up by @simianhacker in #5947 (found it when I searched to see if this was already an open issue), but it probably needs its own issue.

@epixa epixa added the discuss label Jan 25, 2016
@simianhacker
Copy link
Member

I think it would be great to come up with an angular directive that every plugin author could use for this. We use to use modals for things like this in Kibana 3 but we don't really use a modal in Kibana 4. I would be interested in hearing @rashidkpc thoughts on this.

@kimjoar
Copy link
Contributor

kimjoar commented Jan 25, 2016

Also a good thing for @alt74 to think about

@rashidkpc
Copy link
Contributor

Yeah, I agree with the OP here. IMHO we should expand the Notify service to be a 2 way thing in which notifications become actionable events.

@Bargs Bargs mentioned this issue Feb 2, 2016
@epixa epixa added Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc release_note:enhancement and removed discuss labels Dec 26, 2016
@stacey-gammon stacey-gammon self-assigned this Jan 9, 2017
@stacey-gammon
Copy link
Contributor

Fixed by #9859

@epixa epixa added enhancement New value added to drive a business result and removed release_note:enhancement labels May 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins.
Projects
None yet
Development

No branches or pull requests

6 participants