Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[uiActions] VALUE_CLICK_TRIGGER and APPLY_FILTER_TRIGGER should be registered by uiActions plugin. #60148

Closed
spalger opened this issue Mar 13, 2020 · 1 comment · Fixed by #60202
Assignees
Labels
bug Fixes for quality problems that affect the customer experience

Comments

@spalger
Copy link
Contributor

spalger commented Mar 13, 2020

we first moved over SELECT_RANGE_TRIGGER but it wasn't enough, we needed to move over more apparently, VALUE_CLICK_TRIGGER and APPLY_FILTER_TRIGGER need to be moved over too it seems.

The SELECT_RANGE_TRIGGER trigger is currently registered with the uiActions plugin by the embeddables plugin, which creates a minor race condition because it's required by the data plugin but we don't want to create an explicit dependency there for this purpose. Instead we should move SELECT_RANGE_TRIGGER into the uiActions plugin.

ERROR browser[SEVERE] http://localhost:6141/bundles/commons.bundle.js 2:3452305 Error: No trigger [triggerId = SELECT_RANGE_TRIGGER] exists, for attaching action [actionId = ACTION_SELECT_RANGE].
          at UiActionsService.attachAction (http://localhost:6141/bundles/plugin/uiActions/uiActions.plugin.js:26:68048)
          at DataPublicPlugin.setup (http://localhost:6141/bundles/plugin/data/data.plugin.js:97:526098)
          at PluginWrapper._callee2$ (http://localhost:6141/bundles/commons.bundle.js:3:1319057)
          at l (http://localhost:6141/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js:338:1041899)
          at Generator._invoke (http://localhost:6141/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js:338:1041652)
          at Generator.forEach.e.<computed> [as next] (http://localhost:6141/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js:338:1042256)
          at asyncGeneratorStep (http://localhost:6141/bundles/commons.bundle.js:3:1316056)
          at _next (http://localhost:6141/bundles/commons.bundle.js:3:1316367)
@spalger spalger added bug Fixes for quality problems that affect the customer experience Team:AppArch labels Mar 13, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@spalger spalger changed the title [uiActions] SELECT_RANGE_TRIGGER should be registered by uiActions plugin. [uiActions] VALUE_CLICK_TRIGGER and APPLY_FILTER_TRIGGER should be registered by uiActions plugin. Mar 14, 2020
@spalger spalger closed this as completed Mar 15, 2020
This was referenced Mar 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants