Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preserveHost config.yml wording seems wrong #6019

Closed
amouat opened this issue Jan 27, 2016 · 1 comment
Closed

preserveHost config.yml wording seems wrong #6019

amouat opened this issue Jan 27, 2016 · 1 comment
Labels
bug Fixes for quality problems that affect the customer experience

Comments

@amouat
Copy link

amouat commented Jan 27, 2016

The config.yml says:

# When this setting’s value is true Kibana uses the hostname specified in the server.host
# setting. When the value of this setting is false, Kibana uses the hostname of the host
# that connects to this Kibana instance.
# elasticsearch.preserveHost: true

But this seems directly contradictory to https://www.elastic.co/guide/en/kibana/current/kibana-server-properties.html

By default, the host specified in the incoming request from the browser is specified as the host in the corresponding request Kibana sends to Elasticsearch. If you set this option to false, Kibana uses the host specified in elasticsearch_url.

I think the on-line docs are correct.

Also, it would be really nice if values such as these could be set in the Docker container via environment variables. Do you want me to open a separate issue for that?

@rashidkpc rashidkpc added bug Fixes for quality problems that affect the customer experience P2 labels Feb 12, 2016
@epixa epixa removed the P2 label Apr 25, 2017
@kobelb
Copy link
Contributor

kobelb commented Mar 19, 2018

Closing in favor of #17242 as this setting doesn't do anything.

@kobelb kobelb closed this as completed Mar 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience
Projects
None yet
Development

No branches or pull requests

4 participants