Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ingest] Add validation on data source configuration fields #60446

Closed
3 tasks
jen-huang opened this issue Mar 17, 2020 · 1 comment · Fixed by #61180
Closed
3 tasks

[Ingest] Add validation on data source configuration fields #60446

jen-huang opened this issue Mar 17, 2020 · 1 comment · Fixed by #61180
Assignees
@jen-huang
Labels
Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project Feature:Fleet Fleet team's agent central management project Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@jen-huang
Copy link
Contributor

Currently there is no validation done on the configure data source form fields. Add validation for:

  • Ensure that required fields are not empty
  • Ensure that yaml type field values are syntactically correct
  • Disable Continue button if there are any validation errors

image
@jen-huang jen-huang mentioned this issue Mar 17, 2020
Closed
22 tasks
@jen-huang jen-huang added Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project Feature:Fleet Fleet team's agent central management project and removed 0.5sp labels Mar 17, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Feature:Fleet)

@jen-huang jen-huang mentioned this issue Mar 18, 2020
Merged
@jen-huang jen-huang self-assigned this Mar 23, 2020
@jen-huang jen-huang mentioned this issue Mar 24, 2020
Merged
@jen-huang jen-huang added the Team:Fleet Team label for Observability Data Collection Fleet team label Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jen-huang jen-huang

Labels
Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project Feature:Fleet Fleet team's agent central management project Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Ingest] Data source configuration validation UI jen-huang/kibana
2 participants
@jen-huang @elasticmachine