Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Alerting UI] Enable edit alert functionality for Uptime alert types from alerting management ui. #60915

Closed
YulNaumenko opened this issue Mar 23, 2020 · 7 comments · Fixed by #55086
Closed

[Alerting UI] Enable edit alert functionality for Uptime alert types from alerting management ui. #60915

YulNaumenko opened this issue Mar 23, 2020 · 7 comments · Fixed by #55086
Labels
bug Fixes for quality problems that affect the customer experience Feature:Alerting Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability

Comments

@YulNaumenko
Copy link
Contributor

Alerting management UI doesn't display Edit button for alert types registered only in external plugins:
img

We should implement ability to edit Uptime alert types from alerting management ui.
@YulNaumenko YulNaumenko added Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Mar 23, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@mikecote mikecote added the bug Fixes for quality problems that affect the customer experience label Mar 23, 2020
@gmmorris
Copy link
Contributor

Am I right in thinking that this is dependent on this: #60135 ?

If so, it should be marked as blocked.

@mikecote
Copy link
Contributor

Am I right in thinking that this is dependent on this: #60135 ?

No, I think this issue is related to a race condition when legacy plugins register alert types in the UI registry. I'd check with @YulNaumenko for more details.

@mikecote
Copy link
Contributor

mikecote commented Mar 25, 2020 •
edited
Loading

Looked into it more. The Uptime UI is a legacy plugin and runs on a separate page than the main Kibana UI. This causes the the uptime alert type to not get registered when accessing the management UIs. We'd have to see what options there are to make it work, if any, otherwise we'll have to wait for Uptime to migrate to the Kibana Platform.

@YulNaumenko YulNaumenko self-assigned this Mar 26, 2020
@mikecote mikecote mentioned this issue Apr 9, 2020
Open
@mikecote mikecote added Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability and removed Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Apr 27, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@mikecote mikecote removed the blocked label Apr 27, 2020
@mikecote
Copy link
Contributor

Removing from Alerting project, issue will resolve once Uptime completes Kibana Platform migration.

@justinkambic
Copy link
Contributor

Uptime client migration tracked here: #55086

@justinkambic justinkambic mentioned this issue Apr 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience Feature:Alerting Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Uptime] Migrate client to New Platform justinkambic/kibana
5 participants
@gmmorris @mikecote @elasticmachine @justinkambic @YulNaumenko