Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Agent span_frames_min_duration configuration input cannot handle 0 or -1 #62569

Closed
estolfo opened this issue Apr 6, 2020 · 1 comment · Fixed by #62777
Closed

[APM] Agent span_frames_min_duration configuration input cannot handle 0 or -1 #62569

estolfo opened this issue Apr 6, 2020 · 1 comment · Fixed by #62777
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Team:APM All issues that need APM UI Team support v7.7.0

Comments

@estolfo
Copy link
Contributor

estolfo commented Apr 6, 2020

Kibana version:
7.7.0-BC2

Elasticsearch version:
7.7.0-BC2

Describe the bug:
The UI can't handle the values 0 and -1 right now for the span_frames_min_duration agent configuration field. Both are valid values for the Ruby and Go agents.
The interface shows an error: Please specify an integer and a unit if either value is entered.
For 0: The UI allows entering in the value 0 but the error message is displayed.
For -1: The UI doesn't allow typing a number starting with -

Steps to reproduce:

  1. Create agent config entry
  2. Navigate to "Span frames minimum duration"
  3. Type 0 or -1, or use the arrows to attempt to enter in either of those values

Expected behavior:
The interface should allow 0 and -1 as valid values.

Screenshots (if relevant):
For 0:
image

For -1:
image

@estolfo estolfo added the Team:APM All issues that need APM UI Team support label Apr 6, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Team:APM All issues that need APM UI Team support v7.7.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants