Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Agent remote config: validation for Java agent configs #62782

Closed
eyalkoren opened this issue Apr 7, 2020 · 2 comments · Fixed by #63956
Closed

[APM] Agent remote config: validation for Java agent configs #62782

eyalkoren opened this issue Apr 7, 2020 · 2 comments · Fixed by #63956
Assignees
@cauemarcondes
Labels
bug Fixes for quality problems that affect the customer experience Team:APM All issues that need APM UI Team support v7.8.0

Comments

@eyalkoren
Copy link
Contributor

Description

Some configuration options are restricted with the values they allow. The Java agent validates those and if they are found invalid, it rejects them and uses the default instead.

Impact

The impact moderate - the invalid values will not be applied as the agent will reject them. It is more a usability issue: the UI lets the user set invalid values and save the configuration, without any indication of a problem. This means the user now assumes the new value is applied, while it is really not.

Details

Following are the config options that require such validation and do not have them:

  • stress_monitor_cpu_duration_threshold - must be at least 1m
  • profiling_inferred_spans_sampling_interval - must be between 1ms and 1s
@eyalkoren eyalkoren added bug Fixes for quality problems that affect the customer experience Team:APM All issues that need APM UI Team support labels Apr 7, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@smith smith mentioned this issue Apr 7, 2020
Closed
@smith
Copy link
Contributor

smith commented Apr 8, 2020

We don't validate min/max with units at this time. Will label this on for 7.8.

@smith smith added the v7.8.0 label Apr 8, 2020
@smith smith removed their assignment Apr 8, 2020
@cauemarcondes cauemarcondes self-assigned this Apr 17, 2020
@cauemarcondes cauemarcondes mentioned this issue Apr 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cauemarcondes cauemarcondes

Labels
bug Fixes for quality problems that affect the customer experience Team:APM All issues that need APM UI Team support v7.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[APM] Agent remote config: validation for Java agent configs cauemarcondes/kibana
5 participants
@smith @sorenlouv @elasticmachine @eyalkoren @cauemarcondes