Region and coordinate maps can no longer zoom beyond level 10 with default distribution

[thomasneirynck]

Kibana version:

7.7, 7.x, Master

Describe the bug:

The license-key parameter is no longer added to request for EMS for the region and coordinate map visualizations. This causes the map not to zoom beyond level 10.

The default distribution of Kibana ships with the tilemap plugin (kibana/x-pack/legacy/plugins/tilemap).

This plugin adds the license-key to all CORS-requests to EMS. This ensures that the user has access to zoom level 18 in the region and coordinate map. It does so by calling a method on the ServiceSettings object.

kibana/x-pack/legacy/plugins/tilemap/public/vis_type_enhancers/update_tilemap_settings.js

Lines 21 to 22 in c2c1253

	serviceSettings.addQueryParams({ license: tileMapPluginInfo.license.uid });
	serviceSettings.disableZoomMessage();

This code-path no longer executes. This causes the map to stop zooming at level 10 and showing a warning.

Steps to reproduce:

1. Run default distribution of Kibana
2. Add the following to kibana.yml:

xpack.maps.showMapVisualizationTypes: true

3. Install sample data, go to Visualize,, open a new coordinate or region maps
4. Zoom-in on the Map -> the Map will stop zooming at level 10

Expected behavior:

In default distribution, the region and coordinate maps shoudl zoom beyond level 10, to level 18.

Screenshots (if relevant):

Provide logs and/or server output (if relevant):

Note that the license parameter is not added to the URLs for EMS

e.g.: from browser console.

https://tiles.maps.elastic.co/styles/osm-bright-desaturated/10/263/392.png?elastic_tile_service_tos=agree&my_app_name=kibana&my_app_version=7.7.0

[elasticmachine]

Pinging @elastic/kibana-gis (Team:Geo)

[elasticmachine]

Pinging @elastic/kibana-app (Team:KibanaApp)

[thomasneirynck]

cc @aaronjcaldwell @joshdover @ppisljar @timroes

It seems like that plugin is the only one that still uses vis_type_enhancers, which I presume got removed. This module (

kibana/x-pack/legacy/plugins/tilemap/public/vis_type_enhancers/update_tilemap_settings.js

Line 11 in c2c1253

uiRoutes.addSetupWork(function($injector, serviceSettings) {

) is not getting executed.

Perhaps any of you know more about this?

[timroes]

Cc @flash1293

[elasticmachine]

Pinging @elastic/kibana-app-arch (Team:AppArch)

[flash1293]

@thomasneirynck @timroes So I checked the code and I'm not 100% sure how ui exports work. But when I interpret

https://github.com/elastic/kibana/blob/master/src/legacy/ui/ui_exports/ui_export_types/ui_app_extensions.js#L62

correctly, then visTypeEnhancers gets wrapped up into visTypes.

The main kibana app bundle stopped pulling in these ui-exports in:

#58337 (c81e0da#diff-da8fc2674a5c5002e66fd47cd70158a4L29)

From what I can tell this is the only place this happened.

[thomasneirynck]

thx @flash1293 for the added context. @aaronjcaldwell proposes to replace this by using hacks #62883, which works as expected.