Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Deangularize Skip to bottom button #65453

Closed
kertal opened this issue May 6, 2020 · 5 comments · Fixed by #69811
Closed

[Discover] Deangularize Skip to bottom button #65453

kertal opened this issue May 6, 2020 · 5 comments · Fixed by #69811
Assignees
Labels
Feature:Discover Discover Application Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@kertal
Copy link
Member

kertal commented May 6, 2020

The part of Discover displaying a Skip to bottom Button is still Angular. It should be converted to React using EUI. Note that it's only displayed when it gets focus, it's here for keyboard navigation.

Bildschirmfoto 2020-05-06 um 13 10 52

Note that it's part of the legacy table, to be removed with EuiDataGrid

Here's the current markup in the Angular Template:

Instructions how to do this are similar to #65326

How to view the button: Set focus on
Bildschirmfoto 2020-06-24 um 10 49 29

Use shift-Tab to navigate back to the button, that should be visible then

@kertal kertal added Feature:Discover Discover Application Team:Visualizations Visualization editors, elastic-charts and infrastructure labels May 6, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@kertal
Copy link
Member Author

kertal commented May 6, 2020

Dear @myasonik, from a11y standpoint, does it even make sense the way it's currently implemented for the legacy table (Won't be needed when we use EuiDataGrid, that's for sure)?

@myasonik
Copy link
Contributor

myasonik commented May 6, 2020

Nope, the current implementation isn't worth keeping around once DataGrid is implemented. (It's axed in my PR.)

I'd probably just leave it as is and phase it out at the same time as the current Discover table.

@kertal
Copy link
Member Author

kertal commented May 7, 2020

@myasonik I'm aware it makes no sense for DataGrid, but for the legacy mode it makes sense, right? thx

@myasonik
Copy link
Contributor

myasonik commented May 7, 2020

Yeah, I'd keep it for the legacy mode

@dej611 dej611 self-assigned this Jun 24, 2020
@dej611 dej611 linked a pull request Jun 24, 2020 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Discover Discover Application Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants