Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data.search.aggs]: Create expression functions for object types used in agg params #67908

Closed
6 tasks
Tracked by #60126
lukeelmers opened this issue Jun 1, 2020 · 1 comment · Fixed by #103494
Closed
6 tasks
Tracked by #60126
Labels
chore Feature:Aggregations Aggregation infrastructure (AggConfig, esaggs, ...) Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort

Comments

@lukeelmers
Copy link
Member

lukeelmers commented Jun 1, 2020

There are a few agg types which have params which are objects. Currently in the expression functions for each agg type, we handle these params by passing the objects as stringified JSON (which is not ideal)

Instead each arg provided for the agg params should be a subexpression using a dedicated function which returns the object in the correct shape.

Here's the current list of agg params which are stringified objects that would need to be converted:

Note that each of these params will also need to add an toExpressionAst method to ensure calling AggConfig.toExpressionAst() returns the expected value

Related to #46902

@lukeelmers lukeelmers added chore Feature:Aggregations Aggregation infrastructure (AggConfig, esaggs, ...) Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) Team:AppArch labels Jun 1, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@exalate-issue-sync exalate-issue-sync bot added impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Apr 20, 2021
@exalate-issue-sync exalate-issue-sync bot added loe:medium Medium Level of Effort and removed loe:small Small Level of Effort labels Apr 29, 2021
@petrklapka petrklapka added 1 and removed 1 labels May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Feature:Aggregations Aggregation infrastructure (AggConfig, esaggs, ...) Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants