Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] X axis styling options #68315

Closed
wylieconlon opened this issue Jun 4, 2020 · 10 comments
Closed

[Lens] X axis styling options #68315

wylieconlon opened this issue Jun 4, 2020 · 10 comments
Assignees
Labels
Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@wylieconlon
Copy link
Contributor

X axis styling needs to be handled a little differently than Y axis styling, because there is only one X axis. These options are potentially part of the Chart-level settings.

Option Notes Done
Change axis title Because there is only one X axis but potentially multiple layers, the title might need to be custom
Hide axis title Not all visualizations need to use a text-based label, especially if the information is conveyed in the title
Hide tick labels Same reasoning as hiding the title
Vertical gridlines Charts library supports many options, but we should make this simple by using a single switch
@wylieconlon wylieconlon added Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Jun 4, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@wylieconlon
Copy link
Contributor Author

Community request to change and hide X axis title: https://discuss.elastic.co/t/lens-request-for-improvement/238285/3

@wylieconlon
Copy link
Contributor Author

cc @flash1293 @mbondyra - this is closely related to the X axis styling options #68314

@stratoula stratoula self-assigned this Jul 14, 2020
@stratoula
Copy link
Contributor

Hide tick labels is not available yet on elastic charts. Found a relevant issue elastic/elastic-charts#312. So we could either prioritize it on elastic charts or instead of hiding the tick labels, give the user the possibility to hide the entire axis.

What do you think? @flash1293 @wylieconlon

@flash1293
Copy link
Contributor

@stratoula Can you make a screenshot of how that would look like?

@stratoula
Copy link
Contributor

Yes so let's assume that this is my chart with the x-axis displayed:
Screenshot 2020-07-14 at 6 14 28 PM

And this is my chart with the x-axis hidden:
Screenshot 2020-07-14 at 6 15 13 PM

The drawback here is that the whole axis is hidden (with the title) so if we go with it, it should be temporary on my point of view.

@flash1293
Copy link
Contributor

Thanks for the screenshot. I think for now we can go with the workaround Caroline described in the elastic-charts issue. Once hidden labels become available, we can switch that out in the Lens renderer and the additional space disappears.

@stratoula
Copy link
Contributor

@nickofthyme informed me that they are going to release it soon so let's keep it in track here :) I can work with Caroline's workaround for now!

@nickofthyme
Copy link
Contributor

FYI here is the PR elastic/elastic-charts#711

@flash1293
Copy link
Contributor

Closed by same PR as #68314

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

5 participants