Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid time range in URL causes exception in TopNavMenu #69941

Closed
kertal opened this issue Jun 25, 2020 · 1 comment · Fixed by #70948
Closed

Invalid time range in URL causes exception in TopNavMenu #69941

kertal opened this issue Jun 25, 2020 · 1 comment · Fixed by #70948
Assignees
@lizozom
Labels
bug Fixes for quality problems that affect the customer experience Feature:Query Bar Querying and query bar features impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort

Comments

@kertal
Copy link
Member

kertal commented Jun 25, 2020

Kibana version:
master to 7.7
Describe the bug:

Providing an invalid time range by URL causes an Exception in the Query bar in Discover, Visualize, Dashboard

Going to this URL:
app/discover#/?_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:now-15m,to:nafdsdsfow))&_a=(columns:!(_source),filters:!(),index:'90943e30-9a47-11e8-b64d-95841ca0b247',interval:auto,query:(language:kuery,query:''),sort:!())

Loads discover, but the query bar disappears because an uncaught error is thrown in the react component:

Screenshot 2020-06-25 at 09 59 20

date_modes.js:31 Uncaught TypeError: Cannot read property 'includes' of null
    at getDateMode (date_modes.js:31)
    at isRelativeToNow (pretty_duration.js:68)
    at prettyDuration (pretty_duration.js:110)
    at renderSharingMetaFields (query_bar_top_row.tsx:165)
    at QueryBarTopRow (query_bar_top_row.tsx:305)
    at renderWithHooks (react-dom.development.js:16260)
    at mountIndeterminateComponent (react-dom.development.js:18794)
    at beginWork$1 (react-dom.development.js:20162)
    at HTMLUnknownElement.callCallback (react-dom.development.js:336)
    at Object.invokeGuardedCallbackDev (react-dom.development.js:385)
@kertal kertal added Feature:Dashboard Dashboard related features Feature:Discover Discover Application triage_needed Team:AppArch labels Jun 25, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@kertal kertal added the bug Fixes for quality problems that affect the customer experience label Jun 25, 2020
@kertal kertal mentioned this issue Jun 25, 2020
Merged
3 tasks
@Dosant Dosant added Feature:Query Bar Querying and query bar features impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort triaged and removed Feature:Dashboard Dashboard related features Feature:Discover Discover Application triage_needed labels Jun 25, 2020
@lizozom lizozom self-assigned this Jul 5, 2020
@lizozom lizozom mentioned this issue Jul 7, 2020
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lizozom lizozom

Labels
bug Fixes for quality problems that affect the customer experience Feature:Query Bar Querying and query bar features impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Validate incoming url timerange lizozom/kibana
4 participants
@kertal @lizozom @Dosant @elasticmachine