Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embeddable Panel is not reactive to Input Updates #70381

Closed
Tracked by #71857
ThomThomson opened this issue Jun 30, 2020 · 2 comments · Fixed by #74253
Closed
Tracked by #71857

Embeddable Panel is not reactive to Input Updates #70381

ThomThomson opened this issue Jun 30, 2020 · 2 comments · Fixed by #74253
Labels
bug Fixes for quality problems that affect the customer experience Feature:Embedding Embedding content via iFrame impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:medium Medium Level of Effort release_note:enhancement Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@ThomThomson
Copy link
Contributor

Updating the explicit input of an embeddable in a container does not cause the embeddable panel to re-render that embeddable.

This has caused a number of problems recently:

  • After editing a lens embeddable by value, upon returning to the dashboard, a new id must be generated and the entire panel must be replaced.
  • The dashboard by value example won't respond properly to input updates on its children
  • Showing a placeholder when cloning a panel requires that a new id be generated, and that the placeholder is completely deleted after loading is finished.

Fixing this issue may require changes in multiple places, but the system should be able to support:

  • The type of a panel changing, while retaining the same embeddable ID. This means changing the factory.
  • The savedObjectId changing should trigger the loading of the new saved object.
  • In 'by value' cases, changing out the attributes should properly cause a re-render.
@ThomThomson ThomThomson added release_note:enhancement Feature:Embedding Embedding content via iFrame Team:Visualizations Visualization editors, elastic-charts and infrastructure Team:AppArch labels Jun 30, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@stacey-gammon stacey-gammon added the bug Fixes for quality problems that affect the customer experience label Jul 16, 2020
@streamich streamich mentioned this issue Aug 3, 2020
33 tasks
@dej611 dej611 self-assigned this Aug 4, 2020
@Dosant Dosant added impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:medium Medium Level of Effort triaged labels Sep 28, 2020
@timroes timroes added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Oct 7, 2020
@dej611 dej611 removed their assignment Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Embedding Embedding content via iFrame impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:medium Medium Level of Effort release_note:enhancement Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants