Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Assistant surfaces confusing error state for deprecation logging toggle #73211

Closed
cjcenizal opened this issue Jul 24, 2020 · 1 comment · Fixed by #97294
Closed

Upgrade Assistant surfaces confusing error state for deprecation logging toggle #73211

cjcenizal opened this issue Jul 24, 2020 · 1 comment · Fixed by #97294
Labels
enhancement New value added to drive a business result Feature:Upgrade Assistant Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@cjcenizal
Copy link
Contributor

During a discussion with @LeeDr (#70071 (review)), we discovered that there's a UX bug when the deprecation logging toggle gets back an error after sending its request. The UX is currently designed like this:

  1. User clicks toggle
  2. Toggle flips state (on to off or off to on)
  3. Toggle becomes disabled
  4. API request is sent
  5. API request resolves successfully and toggle is enabled

Here's how it looks:

ua_toggle

However, if the API request resolves with an error, the toggle is stuck in an incorrect state ("on" when it's really "off", or vice versa), and it remains disabled so you can't try clicking it again.

ua_toggle_error

One solution could look like this:

  • Show a spinner and "Updating" message when the toggle is clicked.
  • If the current state can't be retrieved, replace the toggle with a "Reload" button and a "Can't load deprecation logging information" error message.
@cjcenizal cjcenizal added enhancement New value added to drive a business result Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more Feature:Upgrade Assistant labels Jul 24, 2020
@LeeDr
Copy link
Contributor

LeeDr commented Jul 25, 2020

Agreed. The general flow for clicking a toggle button in Kibana which does a request to Elasticsearch should be to;

  1. disable the toggle
  2. change state only if the response confirms the request
  3. re-enable the toggle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Upgrade Assistant Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants