Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport Request - Remove regex flags parameter from terms and significant terms aggs #7408

Closed
djschny opened this issue Jun 9, 2016 · 7 comments
Labels
backport bug Fixes for quality problems that affect the customer experience Feature:Visualizations Generic visualization features (in case no more specific feature label is available)

Comments

@djschny
Copy link
Contributor

djschny commented Jun 9, 2016

See the following:

It looks like Kibana was never updated to remove these kind of options and be compatible with ES 2.x

@Bargs
Copy link
Contributor

Bargs commented Jun 10, 2016

@djschny where are you seeing the CASE_INSENSITIVE option? I'm looking at the terms agg options in master but I'm not seeing it.

@djschny
Copy link
Contributor Author

djschny commented Jun 10, 2016

See attached screenshot. It is with Kibana 4.5.0

screen shot 2016-06-10 at 10 20 14 am

@Bargs Bargs added bug Fixes for quality problems that affect the customer experience backport labels Jun 10, 2016
@Bargs Bargs changed the title Kibana showing CASE_INSENSITIVE option but it was removed from ES Backport Request - Remove regex flags parameter from terms and significant terms aggs Jun 10, 2016
@Bargs
Copy link
Contributor

Bargs commented Jun 10, 2016

Ah ha, thanks. Looks like this was fixed in 5.0, but wasn't backported #6875. I've edited the title to reflect that this is a backport request.

@tbragin tbragin added the Feature:Visualizations Generic visualization features (in case no more specific feature label is available) label Feb 14, 2017
@tbragin
Copy link
Contributor

tbragin commented Feb 14, 2017

@djschny Do you still think this is critical to backport to 4.x?

@djschny
Copy link
Contributor Author

djschny commented Feb 14, 2017

@tbragin Back in summer of last year when the ticket was entered, yes. Given that we are now 8 months later and v5.x has been out for a good amount, does not seem necessary anymore.

@tbragin
Copy link
Contributor

tbragin commented Feb 14, 2017

@djschny Agreed. Sorry we didn't get to it in time. :( I'll close it -- please comment or reopen if you see a big need for it going forward.

@tbragin tbragin closed this as completed Feb 14, 2017
@djschny
Copy link
Contributor Author

djschny commented Feb 14, 2017

No worries! It was a minor thing compared to other priorities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport bug Fixes for quality problems that affect the customer experience Feature:Visualizations Generic visualization features (in case no more specific feature label is available)
Projects
None yet
Development

No branches or pull requests

3 participants