Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Edit swim lane on a dashboard opens two flyouts #76932

Closed
Dosant opened this issue Sep 8, 2020 · 1 comment · Fixed by #79850
Closed

[ML] Edit swim lane on a dashboard opens two flyouts #76932

Dosant opened this issue Sep 8, 2020 · 1 comment · Fixed by #79850
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:Anomaly Detection ML anomaly detection loe:small Small Level of Effort :ml Project:Accessibility v7.10.0

Comments

@Dosant
Copy link
Contributor

Dosant commented Sep 8, 2020

Kibana version: 7.8+, master
Describe the bug:

There's an EuiFlyout inception that is happening when opening the "JobSelectorFlyout" flyout from Dashboard.

Steps to reproduce:

  1. Open a dashboard with swim lane
  2. Edit swim lane
  3. Watch as you see two levels of flyouts appear during the animation. Once they're fully open it's hard to tell until you search the rendered dom.

Screenshot 2020-09-08 at 14 49 04

Expected behavior:

One flyout. The two flyouts can cause the animation to be sluggish and stutter. It will also cause problems with the EUI upgrade that pushes the panel below the header. Nested flyouts will double that amount.

Any additional context:

  1. Same as [Dashboard] Add panel flyout opens 2 flyouts #64789
  2. Example fix: [bugfix] Add panel flyout opens 2 flyouts #65861
  3. Issue is caused by using core.overlays.openFlyout(<EuiFlyout></EuiFlyout>). <EuiFlyout/> - shouldn't be used in this case, as core adds own one.
@Dosant Dosant added bug Fixes for quality problems that affect the customer experience Project:Accessibility Feature:Anomaly Detection ML anomaly detection labels Sep 8, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Anomaly Detection ML anomaly detection loe:small Small Level of Effort :ml Project:Accessibility v7.10.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants