Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Uptime UI] add filter capabilities to waterfall #80167

Closed
katrin-freihofner opened this issue Oct 12, 2020 · 5 comments · Fixed by #89185
Closed

[Uptime UI] add filter capabilities to waterfall #80167

katrin-freihofner opened this issue Oct 12, 2020 · 5 comments · Fixed by #89185
Assignees
Labels
Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability test-plan test-plan-ok issue has passed test plan v7.12.0

Comments

@katrin-freihofner
Copy link
Contributor

katrin-freihofner commented Oct 12, 2020

Describe the feature:
Please introduce a filter and search capabilities on top of the waterfall resource list. It should support searching for text and filtering for a specific MIME type (single-select). Please use the EUI filter group for the filter capabilities https://elastic.github.io/eui/#/forms/filter-group and the EUI search field https://elastic.github.io/eui/#/forms/form-controls#search-field.

What is special about these filters is the fact, that they won't remove rows that do not match the filter, but only desaturate them.

Both, searching and filtering will remove all elements that don't match form the list.

The filter icon button triggers a popover containing the filter buttons. The icon button should change it's color if a filter is selected (this behavior is also described as changing visual appearance: https://elastic.github.io/eui/#/navigation/button#toggle-buttons).
Screenshot 2021-01-12 at 09 50 25

As soon as a filter is selected, the popover disappears and the waterfall updates. (To remove a mime type filter, the filter button needs to be clicked again.)
Screenshot 2021-01-12 at 09 50 41

Please add telemetry support:

  • to track if the search is used
  • to track if the filter buttons are used.

Figma file

@katrin-freihofner katrin-freihofner added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Oct 12, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@shahzad31
Copy link
Contributor

From offline discussion it's decided that search will be offline on already fetched up to 1000 network requests.

@drewpost
Copy link

Documenting conversation. For this iteration we will "dim" the non matching search results instead of hiding them. This is to maintain context with the other objects and enable users to still see the impact a highlighted object had on subsequent objects and the overall page load.

@katrin-freihofner
Copy link
Contributor Author

I spoke to @drewpost about letting users combine text search and filters. We think we should enable users to do so. I just want to make sure we are all on the same page about this?
@shahzad31 @paulb-elastic

@shahzad31
Copy link
Contributor

shahzad31 commented Jan 25, 2021

As far i can understand, it will be an AND operation, i mean between filters and text search.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability test-plan test-plan-ok issue has passed test plan v7.12.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants