Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Switch from _source to fields when fetching data #80517

Closed
11 tasks
kertal opened this issue Oct 14, 2020 · 4 comments
Closed
11 tasks

[Discover] Switch from _source to fields when fetching data #80517

kertal opened this issue Oct 14, 2020 · 4 comments
Labels
Feature:Discover Discover Application Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@kertal
Copy link
Member

kertal commented Oct 14, 2020

Currently data displayed in Discovers grid is taken from _source (except scripted fields and date & date_nanos fields, which are requested by using docvalue_fields). For this reason multi fields (e.g. field.keyword), alias field, and the upcoming new kid on the field block called runtime field #77107 can be selected, but there's no value displayed in the document table.

How much adaptions are necessary depends on how data is returned when using fields, currently fields is returned destructured, but since Discover is currently using _source which is structured this would be a very different behavior.

What parts of Discover would need adaptation, when fields is ready to usage?

Fields API change checklist

  • Support unmapped fields
  • Multi fields in extended document view
  • Support nested fields unflattened (waiting for ES API)
  • Make individual document viewer work with fields API
  • Improve "visualize" button for multi-fields
  • Handling of meta fields in the sidebar

Requirements:

Support request for fields in high level search service. #77241

@kertal kertal added the Feature:Discover Discover Application label Oct 14, 2020
@kertal kertal added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Oct 14, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@lukeelmers
Copy link
Member

Now that #82383 has merged, this should be unblocked 🙂

@timroes
Copy link
Contributor

timroes commented Dec 8, 2020

As of the latest discussion, ES team (@cbuescher) will begin work on the fields API to represent nested fields in query in an unflattened way. As soon as we have something ready, let's link it here. I've outlined the major expectations to the API from our side:

  • Nested fields should be returned as structured (JSON) content from the closest to root nested object.
  • Ideally (read optionally) they should not ALSO appear flattened, otherwise we'd need to filter out the flattened version in Discover.
  • Whether this is default behavior or requires some request parameter is up to ES to decide.
  • This behavior is specific for nested fields and no other type.

@timroes
Copy link
Contributor

timroes commented Feb 23, 2021

Closed via #83891 and more, tracking remaining work in #88426

@timroes timroes closed this as completed Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Discover Discover Application Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

4 participants