Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for cyclic SO references #80966

Closed
Dosant opened this issue Oct 19, 2020 · 1 comment · Fixed by #81582
Closed

Support for cyclic SO references #80966

Dosant opened this issue Oct 19, 2020 · 1 comment · Fixed by #81582
Labels
enhancement New value added to drive a business result Feature:Saved Objects Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@Dosant
Copy link
Contributor

Dosant commented Oct 19, 2020

In scope of this issue we need to make sure that features that rely on saved object references support cyclic references.

Cyclic reference use-case came up in: #71409 (comment), where dashboards can link to each other via drilldowns.

From a quick poc it became clear that saved object reference system isn't implemented or wasn't tested to gracefully support cyclic references.

Example setup:

  • Dashboard A is linking to Dashboard B via dashboard drilldown
  • Dashboard B is linking to Dashboard A via dashboard drilldown

SO Relations UI:

(Looks good)

Screenshot 2020-10-19 at 14 02 13

Export Dashboard A with related objects:

Error:

{"statusCode":400,"error":"Bad Request","message":"circular reference: [dashboard:09599400-0fa8-11eb-9974-3fd3df6ee7d4] ref-> [dashboard:f61a0eb0-0fa7-11eb-9974-3fd3df6ee7d4] ref-> [dashboard:09599400-0fa8-11eb-9974-3fd3df6ee7d4]"}

Copy Dashboard A to different space:

Error:

{"statusCode":500,"error":"Internal Server Error","message":"An internal server error occurred."}

TODO: check other features that rely on references (no sure what else...)


Needed for #71409

@Dosant Dosant added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc enhancement New value added to drive a business result Feature:Saved Objects labels Oct 19, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Saved Objects Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants