Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dev/cli] switch from "cluster" to "child_process" module #83976

Closed
spalger opened this issue Nov 20, 2020 · 1 comment · Fixed by #84726
Closed

[dev/cli] switch from "cluster" to "child_process" module #83976

spalger opened this issue Nov 20, 2020 · 1 comment · Fixed by #84726
Assignees
@spalger
Labels
enhancement New value added to drive a business result Team:Operations Team label for Operations Team

Comments

@spalger
Copy link
Contributor

spalger commented Nov 20, 2020 •
edited
Loading

In Node 12 it seems the cluster module gets tripped up, causing an EPIPE error to be logged when killing the dev server is shut down in some cases. Additionally we have less control over how the process is spawned and have to use global setup/state stuff that is undesirable, so I'm moving the dev cli to use execa instead of the cluster module as a way to clean these up.
@spalger spalger added bug Fixes for quality problems that affect the customer experience Team:Operations Team label for Operations Team labels Nov 20, 2020
@spalger spalger self-assigned this Nov 20, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@spalger spalger mentioned this issue Nov 20, 2020
Merged
@spalger spalger added enhancement New value added to drive a business result and removed bug Fixes for quality problems that affect the customer experience labels Nov 23, 2020
@spalger spalger mentioned this issue Dec 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spalger spalger

Labels
enhancement New value added to drive a business result Team:Operations Team label for Operations Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[cli/dev] remove cluster module, modernize, test spalger/kibana
2 participants
@spalger @elasticmachine