Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser back/forward does not update filtered data #84711

Closed
nickofthyme opened this issue Dec 1, 2020 · 4 comments
Closed

Browser back/forward does not update filtered data #84711

nickofthyme opened this issue Dec 1, 2020 · 4 comments
Labels
Feature:Aggregations Aggregation infrastructure (AggConfig, esaggs, ...) impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@nickofthyme
Copy link
Contributor

Kibana version:
master

Browser OS version:
Chrome

Describe the bug:
When setting a filter on a visualization in visualize then using the browser back and forward buttons, the filter will be added and removed but the data will remain unchanged until the refresh button is pressed.

This bug affects vis_type_vislib, vis_type_tagcloud and possibly others.

Steps to reproduce:

  1. Go to a tag cloud visualization from any sample dataset
  2. Add a filter
  3. Notice the data and visualization is updated
  4. Click the browser back button, then the forward button
  5. Notice the visualization is unchanged by the filter being added and removed.
  6. Clicking the kibana refresh button on the next state, correctly updates the data.

The behavior is a little flaky, sometime it works correctly on the first back but not all the subsequent forwards and backwards.

Expected behavior:
Filter should update the data passed to the visualization

Screenshots:
Screen Recording 2020-12-01 at 03 30 PM

Errors in browser console (if relevant):
N/A

Any additional context:
After inspecting vislib, the data that is passed to the toExpressionAst function from esaggs is not being updated and using the previous data.

@nickofthyme nickofthyme added Feature:Aggregations Aggregation infrastructure (AggConfig, esaggs, ...) Team:Visualizations Visualization editors, elastic-charts and infrastructure Team:AppArch labels Dec 1, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@nickofthyme nickofthyme changed the title Browser back/forward does not update filters Browser back/forward does not update filtered data Dec 1, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@sulemanof
Copy link
Contributor

Note:
this was 100% working in #67848
Possible regression after: #72093

Folder to investigate: src/plugins/visualize/public/application

@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Jun 21, 2021
@ppisljar
Copy link
Member

ppisljar commented Aug 9, 2022

Thank you for contributing to this issue, however, we are closing this issue due to inactivity as part of a backlog grooming effort. If you believe this feature/bug should still be considered, please reopen with a comment.

@ppisljar ppisljar closed this as not planned Won't fix, can't repro, duplicate, stale Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Aggregations Aggregation infrastructure (AggConfig, esaggs, ...) impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

6 participants