Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule Type implementors can't prevent Creation of their alert types in Rules Management without also preventing Editing #89162

Closed
gmmorris opened this issue Jan 25, 2021 · 16 comments
Labels
estimate:medium Medium Estimated Level of Effort Feature:Alerting/RulesManagement Issues related to the Rules Management UX Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@gmmorris
Copy link
Contributor

@elastic/stack-monitoring have prevented the Creation and Editing of their Alert Types in Alerts Management, but they would actually like to allow Editing - it's only creation that they actually want to block.

It would be nice to allow editing of their alerts in Alerts Management, especially considering we do list these alerts and display their details.

@gmmorris gmmorris added the Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) label Jan 25, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@gmmorris gmmorris changed the title Alert Type implementors can't prevent Creation of their alert types in Alerts Management, without also preventing Editing Alert Type implementors can't prevent Creation of their alert types in Alerts Management without also preventing Editing Jan 25, 2021
@mikecote
Copy link
Contributor

Note that stack monitoring alerts may eventually move to pre-configured alerts which would solve the issue for them (prevent creation & have singleton alerts).

@gmmorris
Copy link
Contributor Author

Note that stack monitoring alerts may eventually move to pre-configured alerts which would solve the issue for them (prevent creation & have singleton alerts).

Yup, now that @chrisronline ran through their rationale with me, it makes sense.

@mikecote
Copy link
Contributor

similar scenario to when alerts can only be edited within the application (ex: detection alerts).

@mikecote
Copy link
Contributor

mikecote commented Feb 4, 2021

Moving from 7.x - Candidates to 8.x - Candidates (Backlog) after the latest 7.x planning session.

@chrisronline
Copy link
Contributor

Is this much work to support? I'd be happy to do it if it's a relatively small effort.

@mikecote
Copy link
Contributor

mikecote commented Feb 5, 2021

Is this much work to support? I'd be happy to do it if it's a relatively small effort.

@chrisronline I think it's relatively small, it would be great if you can help. We would just need to figure out what proposal works best for such an approach, but feel free to suggest something or let us know if you just need a direction.

@ravikesarwani
Copy link
Contributor

Hi @chrisronline Do you know of issues if user creates a new alert using one of the stack monitoring alert types? The reason I ask is if we can handle this issue in 2 steps:

  1. For 7.12 toggle the flag so that user can see the alert details (threshold etc) and modify them from the Alerts and Actions section.
  2. For later release we can add more granular control between create and edit.
    WDYT?

@chrisronline
Copy link
Contributor

@ravikesarwani

This is the original issue: #75414

It looks like the original issue (the screenshot where you couldn't configure the CPU usage alert) is now fixed:
Screen Shot 2021-02-10 at 1 58 17 PM

We can change it so users can do the above screenshot if you want. I'm worried that creating more of these alerts will lead to confusion, because they can't really change the index pattern or add any filters.

LMK

@ravikesarwani
Copy link
Contributor

@chrisronline , in 7.11 we have an indication in the create flow that this is stack monitoring related. Can you confirm?
If this is the case then I think the flow now is much better to enable it?
Previously with no indication I think "CPU Usage" was very general and can confuse the observability users.

I would still like to pursue the change where we have granular control over create and edit and then we can disable the create action.

@chrisronline
Copy link
Contributor

in 7.11 we have an indication in the create flow that this is stack monitoring related

I don't think so. The screenshot above is master and I don't think anything has changed between 7.11 and master. The alert is just called (for example) CPU Usage without any indication that it's enabled by default by Stack Monitoring. The screenshot above is what the user would see, unless I'm missing something?

@ravikesarwani
Copy link
Contributor

Hmm... This is what I see in 7.11 =>
Screen Shot 2021-02-10 at 4 16 10 PM
Screen Shot 2021-02-10 at 5 20 20 PM

@ravikesarwani
Copy link
Contributor

ravikesarwani commented Feb 10, 2021

There are use cases where user smay want to alert when CPU is 75% for last 5 minutes and call that a warning and send an email. When its 85% for last 10 minutes they call that an error and want to send a pagerduty alert.
Allowing creation of new alerts can help with that.

There is extension to the use case where a user want to create a new alert and apply to only some of the objects as well.

@chrisronline
Copy link
Contributor

Hmm... This is what I see in 7.11 =>

Exactly. There isn't a monitoring-related alert type in the list. It sounds like we want to change that and allow users to create and edit stack monitoring alerts from the Alerts Management UI. Is that true?

@ravikesarwani
Copy link
Contributor

I created 91145 to change the behaviour for stack monitoring alerts.

@gmmorris gmmorris added Feature:Alerting Feature:Alerting/RulesManagement Issues related to the Rules Management UX labels Jul 2, 2021
@gmmorris gmmorris added the loe:large Large Level of Effort label Jul 14, 2021
@gmmorris gmmorris added DX Issues related to Developer Experience estimate:medium Medium Estimated Level of Effort and removed DX Issues related to Developer Experience labels Aug 13, 2021
@gmmorris gmmorris removed the loe:large Large Level of Effort label Sep 2, 2021
@kobelb kobelb added the needs-team Issues missing a team label label Jan 31, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 31, 2022
@XavierM
Copy link
Contributor

XavierM commented Mar 17, 2022

we going close this issue please be our guess to re-open if need it

@XavierM XavierM changed the title Alert Type implementors can't prevent Creation of their alert types in Alerts Management without also preventing Editing Rule Type implementors can't prevent Creation of their alert types in Rules Management without also preventing Editing Mar 31, 2022
@XavierM XavierM closed this as completed Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
estimate:medium Medium Estimated Level of Effort Feature:Alerting/RulesManagement Issues related to the Rules Management UX Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
No open projects
Development

No branches or pull requests

7 participants