Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Upgrade Assistant] Add A11y test for surfaced deprecations #90707

Closed
cuff-links opened this issue Feb 8, 2021 · 6 comments
Closed

[Upgrade Assistant] Add A11y test for surfaced deprecations #90707

cuff-links opened this issue Feb 8, 2021 · 6 comments
Assignees
Labels
Feature:Upgrade Assistant Project:Accessibility release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more test_ui_functional test_xpack_functional v7.12.0 v8.0.0

Comments

@cuff-links
Copy link
Contributor

Summary

This issue is to add accessibility tests for surfaced deprecations in Upgrade Assistant.

Steps to add

1.) Navigate to Upgrade Assistant
2.) Use ES Archiver to add some data that would surface deprecations on the cluster level and index level.
3.) Navigate to the appropriate tab.
4.) Take the snapshot.

Context:
#90265 (comment)

@cuff-links cuff-links added Project:Accessibility test_ui_functional test_xpack_functional v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes Feature:Upgrade Assistant v7.12.0 labels Feb 8, 2021
@cuff-links cuff-links self-assigned this Feb 8, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-accessibility (Project:Accessibility)

@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@cjcenizal
Copy link
Contributor

@cuff-links Would you mind checking in with Kibana QA and Kibana Core about whether using ES Archiver is still a best practice? I thought I read somewhere that there was a newer preferred alternative.

@cuff-links
Copy link
Contributor Author

@cuff-links Would you mind checking in with Kibana QA and Kibana Core about whether using ES Archiver is still a best practice? I thought I read somewhere that there was a newer preferred alternative.

I will reach out and update the issue.

@cuff-links
Copy link
Contributor Author

@cjcenizal If we are adding test data, we would still use ES Archiver. If we are doing things with the kibana index, then we use the saved objects API. So, in this instance, we would go ahead and use ES Archiver.

@alisonelizabeth
Copy link
Contributor

I'm going to close this issue. The a11y tests should now be testing the UI when there are deprecations. Related work: #109909, #110843.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Upgrade Assistant Project:Accessibility release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more test_ui_functional test_xpack_functional v7.12.0 v8.0.0
Projects
None yet
Development

No branches or pull requests

4 participants