Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard] Save button is not disabled when there are no changes #92366

Closed
stratoula opened this issue Feb 23, 2021 · 4 comments
Closed

[Dashboard] Save button is not disabled when there are no changes #92366

stratoula opened this issue Feb 23, 2021 · 4 comments
Labels
bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@stratoula
Copy link
Contributor

Kibana version:
7.12 - Cloud

Steps to reproduce:

  1. Create a dashboard on a cloud instance
  2. Save it
  3. Click to edit it again, the save button doesn't appear to be disabled even though I haven't changed anything
  4. Important note: I do not reproduce it locally, it only happens to my cloud instance

Expected behavior:
I expect it to work precisely as locally, the save button to be disabled if I haven't done any changes

Screenshots (if relevant):
testing-quick-save-Elastic

@stratoula stratoula added bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Feb 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@stratoula stratoula changed the title [Dashboard] Quick Save is not disabled when there are no changes [Dashboard] Save button is not disabled when there are no changes Feb 23, 2021
@ThomThomson
Copy link
Contributor

Seems like the cloud environment doesn't yet include this PR: #91729

The next build candidate should solve this.

@stratoula
Copy link
Contributor Author

Ok let's wait the next build candidate to confirm that this is solved and let's close it them

@stratoula
Copy link
Contributor Author

@ThomThomson I am closing it. I checked on the new BC and it works!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

No branches or pull requests

3 participants