Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Telemetry] Test helpers for kibana_system #92825

Closed
afharo opened this issue Feb 25, 2021 · 4 comments
Closed

[Telemetry] Test helpers for kibana_system #92825

afharo opened this issue Feb 25, 2021 · 4 comments
Labels
Feature:Telemetry Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@afharo
Copy link
Member

afharo commented Feb 25, 2021

We should provide some test helpers for devs to make sure the data they are collecting is actually accessible by the internal kibana_system.

At the moment, we have the service https://github.com/elastic/kibana/blob/master/x-pack/test/api_integration/services/usage_api.ts that folks can use to retrieve the telemetry in their FTR. We could improve this service by making it more accessible (not only in the X-Pack API Integration tests), and by performing the calls with the right kibana_system user to make sure they can test accordingly.

Then add some documentation and examples encouraging this kind of tests.

@afharo afharo added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:Telemetry Team:KibanaTelemetry labels Feb 25, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-telemetry (Team:KibanaTelemetry)

@afharo
Copy link
Member Author

afharo commented Mar 18, 2021

We could have caught this bug (#94980) earlier if we had these helpers implemented 😢

@afharo
Copy link
Member Author

afharo commented Apr 8, 2021

If #96538 is to be implemented, we might not need to do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Telemetry Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

No branches or pull requests

4 participants