Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Table dynamic coloring: compute overall gradient for split columns #96401

Closed
dej611 opened this issue Apr 7, 2021 · 2 comments
Closed
Labels
discuss enhancement New value added to drive a business result Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@dej611
Copy link
Contributor

dej611 commented Apr 7, 2021

Describe the feature:

The current implementation of dynamic coloring in Lens datatable computes the gradient min/max values per column in isolation.
This could lead to confusing results when using split columns/transposed columns feature as the same value may have assigned a different color.

@mbondyra reported some feedback here:

When having a split columns setup, the gradient is calculated for each column in separation which results to results like this one ('1' has the color of '0' as it's the smallest value for this column):
Screenshot 2021-04-01 at 11 23 41

I agree with the opinion above and this it would be worth to let the user choose how the gradient should be computed in this case:

Transposable columns

How should range be computed for Transposable columns?
This is probably a general "range" discussion about Transposable columns, but in this context, it would be nice to make it clear.
At the moment each column computes its own range and colors are associated in "column isolation".
I may see that in some context it would be nice to have an "overall" range computed for the dimension transposed.
Is the current decision ok? Should I open a new issue for the "overall" option?

Also, maybe we should allow users to choose how to treat missing values as right now in this
chart we sometimes fill empty intervals with '0' and sometimes '-'. The logic we follow for count is to fill the empty intervals with 0 if they lay between truthy values, and '-' if not. So basically in both charts above '0' and '-' is the same thing.

@dej611 dej611 added discuss enhancement New value added to drive a business result Feature:Lens labels Apr 7, 2021
@botelastic botelastic bot added the needs-team Issues missing a team label label Apr 7, 2021
@wylieconlon wylieconlon added Team:Visualizations Visualization editors, elastic-charts and infrastructure and removed needs-team Issues missing a team label labels Apr 7, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@flash1293
Copy link
Contributor

Fixed by #95217

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss enhancement New value added to drive a business result Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

4 participants