Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Telemetry] Deprecate telemetry url configs #96761

Closed
Bamieh opened this issue Apr 12, 2021 · 6 comments · Fixed by #107396
Closed

[Telemetry] Deprecate telemetry url configs #96761

Bamieh opened this issue Apr 12, 2021 · 6 comments · Fixed by #107396
Labels
Breaking Change Feature:Telemetry Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.0.0

Comments

@Bamieh
Copy link
Member

Bamieh commented Apr 12, 2021

We have no useful cases for changing the actual telemetry urls for deployments.

I suggest we deprecate the telemetry url configs (telemetry.url and telemetry.optInStatusUrl) in favor of a telemetry.staging: boolean config. The url paths will be handled internally by the service.

This would be a breaking change for 8.0.0. We'd need to propogate this change internally as well across our testing environments.

@Bamieh Bamieh added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:Telemetry v8.0.0 Team:KibanaTelemetry Breaking Change labels Apr 12, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-telemetry (Team:KibanaTelemetry)

@pgayvallet
Copy link
Contributor

@Bamieh should we add this to #84380?

@afharo
Copy link
Member

afharo commented Apr 14, 2021

We need to sync with the QA and Cloud teams as they are setting those configs when deploying dev, QA and staging deployments.

@Bamieh
Copy link
Member Author

Bamieh commented Apr 21, 2021

Ahh too many meta issues 🙃 I've added it. @afharo yes we need to communicate this breaking change along with all the other breaking changes we'll be shipping in 8.0

@TinaHeiligers
Copy link
Contributor

We need to sync with the QA and Cloud teams as they are setting those configs when deploying dev, QA and staging deployments.

@Bamieh did you sync with QA and the Cloud teams while you were working on #107396?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking Change Feature:Telemetry Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.0.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants