Adding a11y rules from tslint-microsoft-contrib to tslint #26888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 Build Failed |
|
Retest |
💔 Build Failed |
|
Retest |
💔 Build Failed |
tylersmalley
added
the
Team:Core
|
Pinging @elastic/kibana-platform |
💔 Build Failed |
|
Retest |
💔 Build Failed |
|
Retest |
💔 Build Failed |
💔 Build Failed |
|
retest |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
removing non-branch commits removing non-branch commits
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💚 Build Succeeded |
|
@azasypkin @stacey-gammon can you please look this over? It's finally ready to merge 🗡 Thanks! |
|
@azasypkin - do you know why we have a tslint.yaml and a tsconfig.json? The Otherwise, LGTM. |
|
@timroes told me tslint.yaml is for tslint while tsconfig.json is for the actual compiler, so I went ahead and specified tslint.configFile and my VSCode warnings show up! Woot! |
stacey-gammon
approved these changes
Dec 17, 2018
azasypkin
approved these changes
Dec 18, 2018
| @@ -2,15 +2,34 @@ extends: | |||
| - tslint:recommended | |||
| - tslint-config-prettier | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
nit: likely not necessary change.
bhavyarm
added a commit
to bhavyarm/kibana
that referenced
this pull request
Dec 18, 2018
bhavyarm
added a commit
that referenced
this pull request
Dec 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains changes to package.json and tslint.yaml for a11y rules from https://www.npmjs.com/package/tslint-microsoft-contrib
Please note I won't be merging this PR till these PRs are in:
(Needed both alt and presentation)
cc @timroes @LeeDr