Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Composable templates getting silently filtered #1487

Closed
DJRickyB opened this issue May 10, 2022 · 0 comments · Fixed by #1489
Closed

[Bug] Composable templates getting silently filtered #1487

DJRickyB opened this issue May 10, 2022 · 0 comments · Fixed by #1489
Assignees
Labels
bug Something's wrong
Milestone

Comments

@DJRickyB
Copy link
Contributor

DJRickyB commented May 10, 2022

In https://github.com/elastic/rally/blob/master/esrally/track/params.py#L447, we assert that if and only if a provided template has the top-level key "template" is it a composable template. This is not true per the API, and also generally may not be maintainable to try to check spec of things before allowing to send them to Elasticsearch (and fail, and log an error).

It's my belief this is not intentional, particularly as it causes templates provided in the composable-templates entry of a track and without the top-level template field get silently filtered, the task fails with a weird error referencing request_start and there's no information in the log about what happened.

This logic should be more straightforward, providing whatever template(s) I give it as the correct parameter for the create-composable-template task.

As a hint, I think this may mean getting rid of the TemplateParamSource ABC and just spelling out each of its subclasses independently, but I haven't looked that hard at this (as you can tell by my half-hearted attempt in #1486 😄 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something's wrong
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants