Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean-up params #288

Closed
1 of 4 tasks
andrewvc opened this issue May 25, 2021 · 0 comments · Fixed by #331
Closed
1 of 4 tasks

Clean-up params #288

andrewvc opened this issue May 25, 2021 · 0 comments · Fixed by #331

Comments

@andrewvc
Copy link
Contributor

andrewvc commented May 25, 2021

We currently have suite-params (argument), params (variable available in user scripts), and RunParams (internal variable, params + env) in various places in our code. This gets confusing!

We can and should simplify this all pre-GA to:

  • params is the only kind of params, with --suite-params and -s deprecated in favor of -p and --params
  • rename all internal variables to params
  • Get rid of the -e and --environment flag, in favor of NODE_ENV
  • Keep `params as the variable in use in scripts.

While this is a breaking change it is likely that very few people are using these options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants